<cologic> Also I'd like to point out
http://www.adcportal.com/forums/viewtop ... f=32&t=728 again in case e.g. Thor was interested in commenting on it...
<Thor> unavaible -> unavailable << This is my common mistake, don't ask me why :D
<Thor> The addUserCommand/getUserCommands model looks reasonable. But what does it have to do with FavoriteManager? More generally, what is the purpose of FavoriteManager? << ask adrian_007 :) This API base on his removed Lua plugin (as you can see it on the manual)
<cologic> Ah, you're around. Odd to be a common mistake - aible isn't a common sequence to type, so it should be unusual to kind of fall into it via finger/muscle memory
<cologic> Yeah. I'm treating it separately from that though, so some of the questions are half playing-dumb.
<cologic> i.e. if you have something to propose, I'd be interested in reading it, but if it's 'oh well this thing, but without all the stuff that's there for separate, more or less irrelevant reason X which you can read about at URL Y', that's less compelling.
<Thor> The best solution would be if the client would offer enumeration...
<cologic> Of usercommands?
<Thor> For example. I meant about every enums.
<Thor> It might change, but if the startup.lua got them from the core, it would be always fresh and good =)
<cologic> Oh. Well some of them aren't true enums even - I was a bit sloppy (though I tried to fix that), but some of them are bitfields
<cologic> That's almost beside the point I was trying to make. There are (I claim) basically two kinds of enums/bit-value-sets. (1) Those specified in the ADC protocol which startup.lua or dependencies should have their own copies of anyway just as they parse ADC on their own; and (2) those which are pretty much 'oh this is what DC++ so do this too' which I vehemently disagree with existing in the API at all.
<cologic> (I'm not even thrilled with the settings changing/viewing API but it's not terrible to have)